KAZESUI'S PROFILE

author=McBick
Is there a reason I can't include the if statements in a callback that is called multiple times? From my understanding nothing will happen, at worst it will check a single line of execution. I think the battle callbacks are only called 30 times a second, so that means the callback will be called 30 times a second? This seems quite negligible as even the weakest CPUs could run millions of lines of code a second.

if(!myImage["winStats"]){
    myImage["winStats"] = RPG::Image::create(320, 64);
    myImage["winparty"] = RPG::Image::create(320, 64);
    ...
    myText["winStats"] = RPG::Image::create(160, 16);
    ...
}

author=McBick
I believe with the map function it is impossible to have multiples of the same key too, so this should protect me from memory leaks too

std::map<int,RPG::Image*> images;
images[0] = RPG::Image::create();
images[0] = RPG::Image::create();
RPG::Image::destroy(images[0]);

RPG::Image* image;
image = RPG::Image::create();
if(!image)
    image = RPG::Image::create();
RPG::Image::destroy(image);

author=McBick
I think I know why there aren't really any plug-ins that change the default battle system though. There are many issues with the order in which rm2k3 changes battle variables and such. I would have been better off just making my battle system exist independently from the default battle system. Unfortunately that would mean the removal of battle events as well unless I really went out of my way to parse monster group pages and battle events, which would be very time consuming.

author=McBick
@Kazesui
I am cleaning up some of my code and I was wondering how bad is leaving something like this?

void destroyImages() //Checks and destroys any existing Image objects
    {
        if(myImage[0]) //Is there a better way of doing this?
           {
               RPG::Image::destroy(myImage[0]);
               myImage[0] = NULL;
           }
           if(myImage[1])
           {
               RPG::Image::destroy(myImage[1]);
               myImage[1] = NULL;
           }
           for(int i=0; i<8; i++)
           {
               if(myText[i])
               {
                   RPG::Image::destroy(myText[i]);
                   myText[i] = NULL;
               }
           }
    }
void getCustomWindows(std::string loc[], RPG::Window* currentWindow)
    {
        //This function is called every frame, I think? it exists in onBattleStatusWindowDrawn
        CBS::destroyImages(); 
        if(!myImage[0]) //Load Window Image
        {
            myImage[0] = RPG::Image::create();
            myImage[0]->loadFromFile(loc[3]);
            myImage[0]->useMaskColor = true;
        }
        RPG::screen->canvas->draw(0, 140, myImage[0]);
        if(!myText[0]) //Load Text Image
        {
            myText[0] = RPG::Image::create(320, 80);
            myText[0]->setSystemPalette();
            myText[0]->useMaskColor = true;
        }
//The rest of the script builds the text onto the window and such.
...
}

Basically my question is, how bad is it to create and destroy the same objects every frame, especially considering these are Image objects and will be redrawn every frame? It actually only destroys the Image if it exists, but it will always exist since they're created right after the destroy function is called, so it is an endless cycle until the condition to call getCustomWindows becomes false. I have this destroy function at the beginning of all my functions that create Image objects, so I don't have to worry about memory leaks or keeping track of them. Something to note is that the Images aren't dynamic, so I can't just call the function once as it needs to be updated constantly to take into account any changes.

After reviewing this code I have noticed it is a very crude way of doing what I want. Right now I am almost finished with this plugin and just want to fix any bug fixes and release it, at least the first iteration of it. I want to know if this current method I have will cause issues for people who use it though. In my current testing I haven't run into any more issues, but I also haven't done extensive testing with battle events. I plan to do some battle event testing as well, but only things related to message boxes and battle animations as they are the most likely to break my plugin.

author=Kazesui
All arrays have a size, but not a size method. The size method of e.g. std::vector<int> will return the number of elements in the array, not the number of bytes.

std::vector<int> speed;
for(int i=0; i<12; i++)
{
if(i<4 &&RPG::Actor::partyMember(i))
    speed.push_back(RPG::Actor->partyMember(i)->getAgility())
if(i>3 &&RPG::monsters[i])
    speed.push_back(RPG::monsters->getAgility())
}
std::priority_queue<int> queue;
for(int i = 0; i < speed.size(); i++){  
    int value = i  
    value += 100 * speed[i] 
    queue.push(value)
}

... 

int temp = queue.top();  
int currentId = temp % 100; 
queue.pop();  accessible
if(queue.empty()){
}

author=McBick
I am trying to write new variables to be used in the battle calculations in the default battle system. Once I find the memory values that calculate damage in rm2k3 I would like to convert them into pointers, so that I can change those values and write my own battle algorithm. So I need to find a way to write to memory addresses. For example:

int damage = algorithm; //This would be the new formula for damage.
00681422 = damage; //I am aware this would not work, but how would I do something like this?
//This is a random memory value to show what I am trying to do
//Ideally I would overwrite values that exist in rm2k3, so I can 
//create my own damage algorithm. I am aware I would have to change multiple
//memory values to get this to work, but I need to know the proper way
//to alter memory values first

author=McBick
The code for the first issue you mentioned is actually in the previous code I posted. Also if there aren't 12 battlers then the default value of 0 is used and ignores the nonexistent battler.

author=McBick
I am unfamiliar with the use of std::priority_queue structure. Is something like this what you mean?

std::priority_queue<int> bTurn;
for(int n : {bAGI[0], bAGI[1]... BAGI[11]}
    bTurn.push(n);
for(int i=0; i<12; i++)
    if(bAGI[i] == bTurn)
        curBattler = i;
//Battlers are stored as Hero(0-3) and Monster(4-11)
//for the variables of bAGI[Battler Index] and curBattler

std::priority_queue<int> queue;
for(int i = 0; i < bAGI.size(); i++){  // Note, this assume bAGI is a data structure with a size method
    int value = i  // Store the id of the battler in value
    value += 100 * bAGI[i]  // store the agi of the battler * 100 in the value. The multiplication avoids the agi from messing with the battler id
    queue.push(value)
}

... 

int temp = queue.top();  // retrieves the top element
int currentId = temp % 100;  // do this to retrieve the id of the battler
// Let current battler do an action
queue.pop();  // this removes the current top element, making the next one accessible
if(queue.empty()){
    // End of round, refill the queue to start a new round
}

author=McBick
As for my issue with the incorrect turn order, I think I have narrowed it down to the order of operations during battle. I think I have to change which callback the battle initiation takes place, this is what sets up the switches at the start of the battle for the turn order to be called and properly function. I think the issue is that the function getCurrentBattler is being called too early and due to the way the rm2k3 battle code is executed it messes up the synchronicity of my code.